Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in some cases
unzipper
may not extract all the files (see 278 in https://github.com/ZJONSSON/node-unzipper/issues, not linking directly to avoid polluting it with back references) and, with some node versions, it may corrupt some of the extracted files (see 271 in https://github.com/ZJONSSON/node-unzipper/issues). As there is no fix for all that yet (downgradingunzipper
to 0.10.11 might solve the missing extracted files, but it would still be affected by the corrupted files and thus prevent upgrading to a newer node version)unzipper
was replaced byadm-zip
.This could explain the strange errors seen when building the PDF viewer, as well as why the UI was broken after updating the node engines (it would not be a problem in the JavaScript files but in the extracted files, which can be noticed for example in viewer.html).
It would explain too the deleted locale files after the bump to PDF.js 3.9.179 (which are fixed in this pull request).